fix: prevent path traversal via crafted session token in FileTokenStore#142
Merged
devld merged 1 commit intodevld:masterfrom Mar 30, 2026
Merged
Conversation
Signed-off-by: tranquac <tranquac@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent path traversal in
FileTokenStore.getSessionFileby validating the session token contains only UUID-safe characters before using it in file path construction.Problem
getSessionFileconstructs a file path directly from the user-supplied session token:A crafted token containing path traversal sequences (e.g.,
/../../../etc/passwd) can escape the sessions directory:/../../../etc/passwdfilepath.Clean("s_" + "/../../../etc/passwd")resolves to../../etc/passwdfilepath.Join(root, "../../etc/passwd")traverses outside the sessions directoryThis allows:
os.StatinreadFilereveals whether arbitrary files exist and their modification timewriteFilewithos.O_CREATEcould create files at arbitrary pathsFix
Validate that the token contains only UUID-safe characters (
a-f,0-9,-) before constructing the file path. Tokens with any other characters are mapped to a safe invalid path.This is defense-in-depth — it ensures that even if token validation is relaxed elsewhere, the file store cannot be used for path traversal.
Impact
server.FileTokenStore.getSessionFile